Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show device domains if multiple are found #2874

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Feb 20, 2025

Show device domains if multiple are found.

Changes

  • Add optional rpId property to Authenticator.
  • Assign value to this property using existing logic from domainInfo.
  • Split domainInfo into domainLabel to just get the rp Id instead of a TemplateResult.
  • Render rpId if it's non-nullish, see screenshot below.

🟡 Some screens were changed

@sea-snake
Copy link
Contributor Author

image

@sea-snake sea-snake changed the title Show device domains if multiple are found. Show device domains if multiple are found Feb 20, 2025
@sea-snake sea-snake requested a review from lmuntaner February 20, 2025 14:07
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question, but looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants